Bug 113291

Summary: [EFL][Qt] Three inspector test are failing after r146840
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, oliver, ossy, szledan, timothy, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 65829    
Bug Blocks: 79666    
Attachments:
Description Flags
proposed patch none

Ádám Kallai
Reported 2013-03-26 03:22:35 PDT
They are failing after http://trac.webkit.org/changeset/146840. The fails are same on both of ports. * inspector/console/console-eval-syntax-error.html Diff: --- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/console/console-eval-syntax-error-expected.txt +++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/console/console-eval-syntax-error-actual.txt @@ -1,5 +1,5 @@ Tests that evaluating an expression with a syntax error in the console won't crash the browser. Bug 61194. foo(). -SyntaxError: Expected an identifier but found '}' instead +SyntaxError: Unexpected EOF *inspector/debugger/debugger-pause-in-eval-script.html Diff: --- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-pause-in-eval-script-expected.txt +++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-pause-in-eval-script-actual.txt @@ -4,7 +4,7 @@ Evaluated script in console. Script execution paused. Call stack: - 0) testFunction (:3) + 0) testFunction (:2) Script execution resumed. Debugger was disabled. * inspector/extensions/extensions-eval.html --- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/extensions/extensions-eval-expected.txt +++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/extensions/extensions-eval-actual.txt @@ -5,7 +5,7 @@ RUNNING TEST: extension_testEvalConsoleAPI Evaluate: "function" (exception: undefined) RUNNING TEST: extension_testEvalDefinesGlobalSymbols -Evaluate: {"func":"function","variable":42} (exception: undefined) +Evaluate: {"func":"undefined","variable":42} (exception: undefined) RUNNING TEST: extension_testEvalOk Evaluate: {"str":"foo","num":42} (exception: undefined) RUNNING TEST: extension_testEvalStatement
Attachments
proposed patch (10.83 KB, patch)
2013-03-26 08:11 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-03-26 05:49:47 PDT
These results just need added to the platform expectations. They are correct.
Ádám Kallai
Comment 2 2013-03-26 05:53:26 PDT
Thanks for your quick response. I will add new baseline to Qt.
Ádám Kallai
Comment 3 2013-03-26 06:34:57 PDT
Added platform specific expected files in: http://trac.webkit.org/changeset/146876
Csaba Osztrogonác
Comment 4 2013-03-26 06:58:01 PDT
I'm against adding 3 same expected file (Mac/EFL/Qt) for one test. It seems it is JSC/V8 related problem. As far as I remember there was a consensus that in this case the platform independent result should be the JSC specific result and the V8 specific should be in platform-chromium. inspector/console/console-eval-syntax-error.html still have chromium specific result, and its platform independent result is unused now, so it should be updated for JSC platforms. inspector/debugger/debugger-pause-in-eval-script.html and inspector/extensions/extensions-eval.html don't have chromium specific expected file now.
Timothy Hatcher
Comment 5 2013-03-26 07:12:24 PDT
Makes sense to me. JSC is in WebKit, V8 isn't.
Ádám Kallai
Comment 6 2013-03-26 08:11:07 PDT
Created attachment 195089 [details] proposed patch I uploaded a patch for the problem. Ossy thanks for your help. :)
Csaba Osztrogonác
Comment 7 2013-03-26 08:13:01 PDT
Comment on attachment 195089 [details] proposed patch r=me, but let's see if the Mac and the Chromium EWS is happy before landing.
Csaba Osztrogonác
Comment 8 2013-03-28 01:19:50 PDT
Comment on attachment 195089 [details] proposed patch EWS bots are green, let's land it.
WebKit Review Bot
Comment 9 2013-03-28 01:28:38 PDT
Comment on attachment 195089 [details] proposed patch Clearing flags on attachment: 195089 Committed r147083: <http://trac.webkit.org/changeset/147083>
WebKit Review Bot
Comment 10 2013-03-28 01:28:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.