Bug 119034

Summary: [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebKit2Assignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, g.czajkowski, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118643    
Attachments:
Description Flags
Patch andersca: review+

Kwang Yul Seo
Reported 2013-07-23 22:26:53 PDT
The Mac and EFL ports use the same implementation of WebEditorClient::checkTextOfParagraph and GTK will use the same implementation too. So rather than duplicating the same code in platform specific files, move the implementation to platform agnostic WebProcess/WebCoreSupport/WebEditorClient.cpp. See the comment in https://bugs.webkit.org/show_bug.cgi?id=118644#c5
Attachments
Patch (4.15 KB, patch)
2013-07-23 22:28 PDT, Kwang Yul Seo 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2013-07-23 22:28:51 PDT
Created attachment 207373 [details] Patch
Grzegorz Czajkowski
Comment 2 2013-07-23 23:57:07 PDT
Thanks for taking it into consideration! The spelling methods in WebEditorClient.cpp send the message to UIProcess. IMHO would be nice to keep checkTextOfParagraph in WebEditorClient.cpp to avoid code duplication in platform specific files (WebEditorClientMac.mm, WebEditorClientEfl.cpp, WebEditorClientGtk.cpp etc). LGTM.
Kwang Yul Seo
Comment 3 2013-07-30 10:39:01 PDT
Committed r153481: <http://trac.webkit.org/changeset/153481>
Note You need to log in before you can comment on or make changes to this bug.