Bug 12840

Summary: REGRESSION(r16987-r16994): MSN Soapbox content not erased properly
Product: WebKit Reporter: Velimir Ljubic <velimir>
Component: EvangelismAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, markmalone, webkit
Priority: P2 Keywords: InRadar, NeedsReduction, Regression
Version: 420+   
Hardware: Mac (Intel)   
OS: OS X 10.4   
URL: http://soapbox.msn.com
Attachments:
Description Flags
A screenshot of mess
none
Another screenshot of mess none

Velimir Ljubic
Reported 2007-02-21 03:19:23 PST
Hello, many problems in viewing site with latest WebKit as of 21/02/2007. Text is going all over another text and so on... Hope this helps, Velimir
Attachments
A screenshot of mess (46.79 KB, image/png)
2007-02-21 07:07 PST, Velimir Ljubic 		no flags
Details
Another screenshot of mess (96.27 KB, image/png)
2007-02-21 07:12 PST, Velimir Ljubic 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2007-02-21 04:00:46 PST
Could you post a screen shot of what the page looks like? It doesn't look very bad to me, but I'm using a local debug build of WebKit r19729 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127).
Velimir Ljubic
Comment 2 2007-02-21 07:05:43 PST
I am sorry I was not specific enough. It looks OK at first site, but once you try to navigate through videos or comments or other it just overlaps text etc. I will try to upload screenshot. Thanks!
Velimir Ljubic
Comment 3 2007-02-21 07:07:11 PST
Created attachment 13293 [details] A screenshot of mess
Velimir Ljubic
Comment 4 2007-02-21 07:12:06 PST
Created attachment 13295 [details] Another screenshot of mess
Matt Lilek
Comment 5 2007-02-21 16:38:40 PST
Confirmed with r19579, this is also a regression from Safari 2.0.4 The easiest way to see the bug is to view a video then click around the tabs below the video. I'm sure there's a better way to describe this than "erased" but I'm not sure exactly what that is right now...
mitz
Comment 6 2007-02-21 16:49:50 PST
CC:ing Antti since things that don't go away might be visible objects with invisible parents :-) Would be nice to know when the regression happened.
Matt Lilek
Comment 7 2007-02-21 17:57:08 PST
Regressed between r16987 and r16994 with http://trac.webkit.org/projects/webkit/changeset/16988 looking like the culprit.
Antti Koivisto
Comment 8 2007-02-22 07:19:15 PST
Yeah, almost certainly another bug 12368. The site is very ajaxy and bit hard to turn into a local test case but a quick look reveals a Safari test and Safari specific stylesheets setting visibility:visible on some elements, a usual sign of site relying on old buggy Webkit behavior.
David Kilzer (:ddkilzer)
Comment 9 2007-02-22 12:32:34 PST
Per Comment #8, this will most likely be an evangelism issue for soapbox.msn.com.
Antti Koivisto
Comment 10 2007-02-26 18:51:23 PST
Yes, looks like evangelism issue. The script has code like this for hiding the elements on the right: if (window.console) b[c].divElt.style.visibility = "hidden"; else b[c].divElt.style.display = "none"; window.console is a Safari test so e.style.display = "none" gets applied on all non-Safari browsers. Before fix of bug 4377 visibility = "hidden" was enough to hide even visible children, now it is not. The problem in the second screenshot is not a regression, it also happens with shipping Safari. It seems also be related to buggy Safari specific codepaths that do window.console test.
Mark Rowe (bdash)
Comment 11 2007-03-07 06:52:51 PST
<rdar://problem/5045727>
Robert Blaut
Comment 12 2008-12-23 23:34:34 PST
http://soapbox.msn.com redirects now to http://video.msn.com/video.aspx?mkt=en-us&tab=soapbox On this page the is no described issue. Entire page works correctly now. So the bug is fixed.
Note You need to log in before you can comment on or make changes to this bug.