Bug 20468

Summary: Canvas drawImage() doesn't match current specification
Product: WebKit Reporter: Dirk Schulze <krit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
drawImage() updated
none
drawImage() update
none
drawImage() update
none
Canvas drawImage darin: review+

Dirk Schulze
Reported 2008-08-20 15:47:38 PDT
Canvas drawImage() doesn't match current specification. Negative source and destination-rects are aloud now. An INDEX_SIZE_ERR exception is only thrown when sw or sh are zero (like in Firefox).
Attachments
drawImage() updated (12.55 KB, patch)
2008-08-20 15:50 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
drawImage() update (12.56 KB, patch)
2008-08-21 04:16 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
drawImage() update (32.56 KB, patch)
2008-08-21 11:16 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Canvas drawImage (12.35 KB, patch)
2008-08-29 00:20 PDT, Dirk Schulze 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2008-08-20 15:50:31 PDT
Created attachment 22904 [details] drawImage() updated drawImage() matches the specification now and exception are only thrown if sh or sw are zero (like ff). Could only test it on gtk/cairo.
Dirk Schulze
Comment 2 2008-08-21 04:16:54 PDT
Created attachment 22918 [details] drawImage() update added const & to normalizeRect.
Dirk Schulze
Comment 3 2008-08-21 11:16:09 PDT
Created attachment 22921 [details] drawImage() update Added more testcases.
Dirk Schulze
Comment 4 2008-08-29 00:20:35 PDT
Created attachment 23066 [details] Canvas drawImage Removed pixel tests and added getImageData test.
Darin Adler
Comment 5 2008-08-30 23:56:28 PDT
Comment on attachment 23066 [details] Canvas drawImage r=me
Mark Rowe (bdash)
Comment 6 2008-09-02 22:50:17 PDT
Landed in r36043.
Note You need to log in before you can comment on or make changes to this bug.