Bug 224877

Summary: server_process_unittest.py's MockFile should all be bytes
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 224638    
Attachments:
Description Flags
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-04-21 10:15:43 PDT
This can't happen under our current testing setup, but playing with pytest locally on Python 3 I hit: if out_fd in read_fds: data = self._proc.stdout.read() if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()): _log.debug('{} because of no data while reading stdout for the server process.'.format(self._crash_message)) self._crashed = True > self._output += data E TypeError: can't concat str to bytes port/server_process.py:307: TypeError
Attachments
Patch (1.23 KB, patch)
2021-04-21 10:19 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-21 10:16:03 PDT
<rdar://problem/76966005>
Sam Sneddon [:gsnedders]
Comment 2 2021-04-21 10:19:12 PDT
Created attachment 426709 [details] Patch
EWS
Comment 3 2021-04-22 07:49:01 PDT
Committed r276435 (236898@main): <https://commits.webkit.org/236898@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426709 [details].
Note You need to log in before you can comment on or make changes to this bug.