Bug 40903

Summary: [Qt] QScriptValue should have API for accessing object properties
Product: WebKit Reporter: Kent Hansen <kent.hansen>
Component: WebKit QtAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, commit-queue, eric, jedrzej.nowacki, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 40613    
Bug Blocks: 31863    
Attachments:
Description Flags
Partial patch v1
none
Fix v2 none

Attachments
Partial patch v1 (8.32 KB, patch)
2010-06-21 22:05 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Fix v2 (64.25 KB, patch)
2010-07-06 00:53 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2010-06-21 22:05:27 PDT
Created attachment 59336 [details] Partial patch v1 This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features.
Jędrzej Nowacki
Comment 2 2010-06-22 01:43:17 PDT
(In reply to comment #1) > Created an attachment (id=59336) [details] > Partial patch v1 > > This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features. Looks good to me :-). Next time we should be more in sync as I have a patch for this bug (it contains setProperty too). I will rebase mine after yours will be applied. Thanks!
WebKit Commit Bot
Comment 3 2010-06-28 08:20:10 PDT
Comment on attachment 59336 [details] Partial patch v1 Clearing flags on attachment: 59336 Committed r62007: <http://trac.webkit.org/changeset/62007>
WebKit Commit Bot
Comment 4 2010-06-28 08:20:15 PDT
All reviewed patches have been landed. Closing bug.
Caio Marcelo de Oliveira Filho
Comment 5 2010-06-28 10:44:32 PDT
Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-)
Jędrzej Nowacki
Comment 6 2010-07-06 00:48:28 PDT
(In reply to comment #5) > Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-) yes, it would be nice ;-)
Jędrzej Nowacki
Comment 7 2010-07-06 00:53:02 PDT
Created attachment 60600 [details] Fix v2 I added setProperty() and a few additional flags
Kent Hansen
Comment 8 2010-07-06 01:26:54 PDT
(In reply to comment #7) > Created an attachment (id=60600) [details] > Fix v2 > > I added setProperty() and a few additional flags Looks good!
Kenneth Rohde Christiansen
Comment 9 2010-07-06 06:37:48 PDT
Comment on attachment 60600 [details] Fix v2 Great testing as always.
WebKit Commit Bot
Comment 10 2010-07-06 06:55:45 PDT
Comment on attachment 60600 [details] Fix v2 Clearing flags on attachment: 60600 Committed r62547: <http://trac.webkit.org/changeset/62547>
WebKit Commit Bot
Comment 11 2010-07-06 06:55:50 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 12 2010-07-06 07:20:47 PDT
http://trac.webkit.org/changeset/62547 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.