Bug 42802

Summary: Temporarily disable the layout test for the bug 41175
Product: WebKit Reporter: Cosmin Truta <ctruta>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, krit, ojan, zimmermann
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Add an exclusion for the layout test for 41175 under OS X 10.5, until the real problem is fixed
eric: review-
Excluding the layout test for 41175; including the ChangeLog entry none

Cosmin Truta
Reported 2010-07-21 19:29:16 PDT
The fix for the bug 41175 is innocuous; however, the layout test added is failing in debug-mode WebKit on 10.5. Add an exclusion for that layout test, until a proper fix is developed.
Attachments
Add an exclusion for the layout test for 41175 under OS X 10.5, until the real problem is fixed (575 bytes, patch)
2010-07-21 19:44 PDT, Cosmin Truta 		eric: review-
DetailsFormatted DiffDiff
Excluding the layout test for 41175; including the ChangeLog entry (1.10 KB, patch)
2010-07-22 11:57 PDT, Cosmin Truta 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cosmin Truta
Comment 1 2010-07-21 19:44:40 PDT
Created attachment 62255 [details] Add an exclusion for the layout test for 41175 under OS X 10.5, until the real problem is fixed
Eric Seidel (no email)
Comment 2 2010-07-21 19:59:11 PDT
Comment on attachment 62255 [details] Add an exclusion for the layout test for 41175 under OS X 10.5, until the real problem is fixed Every change requires a ChangeLog entry. :(
Cosmin Truta
Comment 3 2010-07-22 11:57:36 PDT
Created attachment 62325 [details] Excluding the layout test for 41175; including the ChangeLog entry
Eric Seidel (no email)
Comment 4 2010-07-22 12:05:19 PDT
Comment on attachment 62325 [details] Excluding the layout test for 41175; including the ChangeLog entry https://bugs.webkit.org/show_bug.cgi?id=41808 does not explain the bug at all. It talks about Chromium, yet this is disabling a test on Mac. I do not understand. Please file a bug about the ASSERT and link to it from your bug and skipped list. Or re-purpose https://bugs.webkit.org/show_bug.cgi?id=41808 to be about the ASSERT itself (with information about what assert and a reduced test case, etc.) This patch is fine, but the course forward is not yet.
Darin Adler
Comment 5 2010-07-22 13:03:16 PDT
Comment on attachment 62325 [details] Excluding the layout test for 41175; including the ChangeLog entry This will disable the test for both Leopard and Tiger. But I suppose it’s better than having the bot fail for days.
WebKit Commit Bot
Comment 6 2010-07-22 18:24:19 PDT
Comment on attachment 62325 [details] Excluding the layout test for 41175; including the ChangeLog entry Clearing flags on attachment: 62325 Committed r63935: <http://trac.webkit.org/changeset/63935>
WebKit Commit Bot
Comment 7 2010-07-22 18:24:25 PDT
All reviewed patches have been landed. Closing bug.
Cosmin Truta
Comment 8 2010-07-27 17:02:33 PDT
The bug 43069 has been opened. That will address the issue of filtering zero-sized <g> elements at a higher, platform-independent level, as opposed to using platform-specific fixes and workarounds. That should hopefully resolve this issue as well.
Note You need to log in before you can comment on or make changes to this bug.