Bug 43918

Summary: REGRESSION(r65225): Broke EFL port build (Requested by acidx on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, jorlow, paroga, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39164    
Attachments:
Description Flags
ROLLOUT of r65225 none

WebKit Review Bot
Reported 2010-08-12 08:04:35 PDT
http://trac.webkit.org/changeset/65225 broke the build: Broke EFL port build (Requested by acidx on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r65225 (8.07 KB, patch)
2010-08-12 08:04 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-08-12 08:04:48 PDT
Created attachment 64226 [details] ROLLOUT of r65225 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2 2010-08-12 08:12:17 PDT
Comment on attachment 64226 [details] ROLLOUT of r65225 Clearing flags on attachment: 64226 Committed r65246: <http://trac.webkit.org/changeset/65246>
WebKit Commit Bot
Comment 3 2010-08-12 08:12:22 PDT
All reviewed patches have been landed. Closing bug.
Jeremy Orlow
Comment 4 2010-08-12 08:17:58 PDT
I don't see why this was rolled out. If you caught a real regression, that'd be one thing, but simply breaking your build isn't a good reason until you have a build bot on build.webkit.org. Until then, there's no way for another port to know they broke you or figure out how to not break you.
Patrick R. Gansterer
Comment 5 2010-08-12 08:33:18 PDT
A buildproblem is not a real regression and doesn't need a rollout. Can you please explain the problem?
Eric Seidel (no email)
Comment 6 2010-08-12 11:26:06 PDT
Isn't efl the only port which uses cmake? I don't see anything wrong with this rollout. But maybe I'm reading wrong?
Patrick R. Gansterer
Comment 7 2010-08-12 11:29:49 PDT
(In reply to comment #6) > Isn't efl the only port which uses cmake? I use it for WinCE too, but it's not in trunk yet. The rollout is correct. I (and other people on IRC) don't know why this happend. ChangeLog doesn't mention and there is no buildbot in the moment to see the buildproblem.
Note You need to log in before you can comment on or make changes to this bug.