Bug 44645

Summary: [BREWMP] Add build system
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore Misc.Assignee: Kwang Yul Seo <skyul>
Status: RESOLVED WONTFIX    
Severity: Normal CC: beergun, commit-queue, eric, joybro201, kevino, xhiloh
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
wscript
none
wscript (JavaScriptCore)
none
wscript none

Kwang Yul Seo
Reported 2010-08-25 16:09:58 PDT
Add build system for BrewMP port.
Attachments
wscript (2.44 KB, patch)
2010-08-25 16:19 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
wscript (JavaScriptCore) (1.44 KB, patch)
2010-08-25 16:34 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
wscript (1.07 KB, patch)
2010-08-27 05:27 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-08-25 16:19:04 PDT
Created attachment 65494 [details] wscript BrewMP will use waf as its build system. Before I upstream the build system for Brew MP, I want to make the current wscript (wx port) more portable.
Kwang Yul Seo
Comment 2 2010-08-25 16:34:59 PDT
Created attachment 65497 [details] wscript (JavaScriptCore) Check build_port.
Kevin Ollivier
Comment 3 2010-08-25 17:46:02 PDT
These look good to me, thanks! :)
WebKit Commit Bot
Comment 4 2010-08-25 20:25:46 PDT
Comment on attachment 65494 [details] wscript Clearing flags on attachment: 65494 Committed r66076: <http://trac.webkit.org/changeset/66076>
WebKit Commit Bot
Comment 5 2010-08-25 20:41:21 PDT
Comment on attachment 65497 [details] wscript (JavaScriptCore) Clearing flags on attachment: 65497 Committed r66078: <http://trac.webkit.org/changeset/66078>
WebKit Commit Bot
Comment 6 2010-08-25 20:41:25 PDT
All reviewed patches have been landed. Closing bug.
Kwang Yul Seo
Comment 7 2010-08-27 05:27:24 PDT
Created attachment 65702 [details] wscript Check Options.options.wxpython only if build_port is "wx".
Kwang Yul Seo
Comment 8 2010-08-27 05:28:33 PDT
Reopen the bug as more patches are coming. How can I prevent the bug from being closed automatically?
Kevin Ollivier
Comment 9 2010-08-28 16:02:30 PDT
Landed the latest patch in r66315. Not using the commit queue is the only way I know of to avoid having it close the bug when all patches have been applied.
WebKit Commit Bot
Comment 10 2010-09-15 01:27:07 PDT
Comment on attachment 65702 [details] wscript Rejecting patch 65702 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kevin Ollivier', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file wscript Hunk #1 FAILED at 181. 1 out of 1 hunk FAILED -- saving rejects to file wscript.rej Full output: http://queues.webkit.org/results/3998021
Kwang Yul Seo
Comment 11 2010-09-15 09:57:17 PDT
(In reply to comment #10) > (From update of attachment 65702 [details]) > Rejecting patch 65702 from commit-queue. > > Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kevin Ollivier', u'--force']" exit_code: 1 > Parsed 2 diffs from patch file(s). > patching file ChangeLog > Hunk #1 succeeded at 1 with fuzz 3. > patching file wscript > Hunk #1 FAILED at 181. > 1 out of 1 hunk FAILED -- saving rejects to file wscript.rej > > Full output: http://queues.webkit.org/results/3998021 Oops. The patch was already submitted by Kevin. Sorry for not clearing "r+" flag.
Eric Seidel (no email)
Comment 12 2010-10-13 12:25:30 PDT
Attachment 65702 [details] was posted by a committer and has review+, assigning to Kwang Yul Seo for commit.
Kwang Yul Seo
Comment 13 2010-10-13 17:57:01 PDT
Comment on attachment 65702 [details] wscript Clear flags because it is already committed.
Kwang Yul Seo
Comment 14 2012-07-26 05:21:19 PDT
Brew MP port is no longer maintained.
Note You need to log in before you can comment on or make changes to this bug.