Bug 45043

Summary: [BREWMP] Add a String constructor which takes AECHAR*
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beergun, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch
none
Patch (StringBrew.cpp)
none
Patch (StringBrew.cpp)
none
Patch (StringBrew.cpp)
none
Patch (StringBrew.cpp) none

Kwang Yul Seo
Reported 2010-09-01 09:36:01 PDT
AECHAR is the wide-char type for BREWMP. Add a String(AECHAR*) constructor for convenience.
Attachments
Patch (1.33 KB, patch)
2010-09-01 09:40 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (StringBrew.cpp) (2.69 KB, patch)
2010-09-01 09:43 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (StringBrew.cpp) (2.67 KB, patch)
2010-09-01 09:49 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (StringBrew.cpp) (2.63 KB, patch)
2010-09-01 09:56 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (StringBrew.cpp) (2.64 KB, patch)
2010-09-01 10:01 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-09-01 09:40:06 PDT
Created attachment 66221 [details] Patch Patch (WTFString.h)
Kwang Yul Seo
Comment 2 2010-09-01 09:43:39 PDT
Created attachment 66222 [details] Patch (StringBrew.cpp)
WebKit Review Bot
Comment 3 2010-09-01 09:44:36 PDT
Attachment 66222 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 4 2010-09-01 09:49:46 PDT
Created attachment 66224 [details] Patch (StringBrew.cpp) I accidentally included <String.h>. Remove it.
WebKit Review Bot
Comment 5 2010-09-01 09:52:29 PDT
Attachment 66224 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 6 2010-09-01 09:56:13 PDT
Created attachment 66226 [details] Patch (StringBrew.cpp) wtf/CString.h is not required here too. Remove it.
WebKit Review Bot
Comment 7 2010-09-01 09:57:29 PDT
Attachment 66226 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 8 2010-09-01 10:01:00 PDT
Created attachment 66227 [details] Patch (StringBrew.cpp) Fix style errors. Put a blank line between the primary header and other header files.
WebKit Review Bot
Comment 9 2010-09-01 10:02:42 PDT
Attachment 66227 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 10 2010-09-01 10:03:43 PDT
(In reply to comment #9) > Attachment 66227 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I think this is a false-positive report because the primary header for StringBrew.cpp is indeed PlatformString.h.
Kent Tamura
Comment 11 2010-10-21 18:27:21 PDT
Comment on attachment 66221 [details] Patch ok
Kent Tamura
Comment 12 2010-10-21 18:28:19 PDT
Comment on attachment 66227 [details] Patch (StringBrew.cpp) ok
WebKit Commit Bot
Comment 13 2010-10-21 21:43:38 PDT
Comment on attachment 66221 [details] Patch Clearing flags on attachment: 66221 Committed r70288: <http://trac.webkit.org/changeset/70288>
WebKit Commit Bot
Comment 14 2010-10-21 22:50:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 66227 [details]: http/tests/appcache/remove-cache.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 15 2010-10-21 22:52:38 PDT
Comment on attachment 66227 [details] Patch (StringBrew.cpp) Clearing flags on attachment: 66227 Committed r70294: <http://trac.webkit.org/changeset/70294>
WebKit Commit Bot
Comment 16 2010-10-21 22:52:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.