Bug 94437

Summary: [V8] Move V8Proxy::callFunction() to ScriptController
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
peter+ews: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-19 17:47:37 PDT
To kill V8Proxy, we can move callFunction() from V8Proxy to ScriptController.
Attachments
Patch (13.32 KB, patch)
2012-08-19 17:55 PDT, Kentaro Hara 		peter+ews: commit-queue-
DetailsFormatted DiffDiff
patch for landing (13.32 KB, patch)
2012-08-19 21:28 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-19 17:55:04 PDT
Created attachment 159312 [details] Patch
WebKit Review Bot
Comment 2 2012-08-19 17:58:26 PDT
Attachment 159312 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/v8/ScheduledAction.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Beverloo (cr-android ews)
Comment 3 2012-08-19 18:15:21 PDT
Comment on attachment 159312 [details] Patch Attachment 159312 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13535572
Adam Barth
Comment 4 2012-08-19 20:43:51 PDT
I'm not sure why this patch fails on Android. Please make sure it builds before landing. ;)
Kentaro Hara
Comment 5 2012-08-19 21:28:33 PDT
Created attachment 159326 [details] patch for landing
Kentaro Hara
Comment 6 2012-08-19 21:30:30 PDT
(In reply to comment #4) > I'm not sure why this patch fails on Android. Please make sure it builds before landing. ;) Wrong: ASSERT(script->proxy) Correct: ASSERT(script->proxy()) cr-linux is build in the Release mode, and thus ASSERT() is ignored. android is build in the Debug mode, and thus ASSERT() is not ignored. Thanks.
WebKit Review Bot
Comment 7 2012-08-19 21:31:40 PDT
Attachment 159326 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/v8/ScheduledAction.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 8 2012-08-19 21:40:37 PDT
That's handy. Thanks for setting up the cr-android bot to build debug.
Kentaro Hara
Comment 9 2012-08-19 22:19:21 PDT
Committed r125998: <http://trac.webkit.org/changeset/125998>
Note You need to log in before you can comment on or make changes to this bug.